Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Dec 17, 2025

Documents PR #19035, which enhances JSON_EXTRACT to support dynamic path arguments (bind variables, function results) instead of only static string literals. Also improves null handling to match MySQL behavior. Static path arguments remain optimized when mixed with dynamic ones.

Trigger Events

Open this suggestion in the Promptless dashboard


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 17, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 17, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 17, 2025
@promptless
Copy link
Contributor Author

promptless bot commented Dec 17, 2025

🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them.

@promptless
Copy link
Contributor Author

promptless bot commented Dec 17, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

I've investigated the CI failure on PR #19045. The issue is that the PR is missing a required "Component:" label.

The fix: Please add the label "Component: Evalengine" to PR #19045. This is the appropriate label since the documentation covers changes to JSON_EXTRACT in the evaluation engine.

Once the label is added, the CI check should pass. Unfortunately, my GitHub integration has read-only access and cannot add labels automatically, so I need you to add it manually.

You can add the label by:

  1. Going to docs: Add changelog entry for JSON_EXTRACT dynamic path arguments #19045
  2. Clicking on the gear icon next to "Labels" in the right sidebar
  3. Selecting "Component: Evalengine"

@promptless
Copy link
Contributor Author

promptless bot commented Dec 17, 2025

🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them.

@arthurschreiber arthurschreiber added Component: Evalengine changes to the evaluation engine and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 17, 2025
@promptless
Copy link
Contributor Author

promptless bot commented Dec 17, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

I've investigated the CI failure on PR #19045. The issue is that the PR is missing two required labels:

Required labels to add:

  1. Component: Evalengine - because the underlying changes are to JSON_EXTRACT in the evaluation engine
  2. Type: Documentation - because this PR adds a changelog entry

How to fix:

  1. Go to docs: Add changelog entry for JSON_EXTRACT dynamic path arguments #19045
  2. Click the gear icon next to "Labels" in the right sidebar
  3. Add both labels: "Component: Evalengine" and "Type: Documentation"

Once both labels are added, the CI check should pass.

My GitHub integration has read-only access and cannot add labels automatically, so I need you to add them manually. Let me know if you need any help!

@promptless
Copy link
Contributor Author

promptless bot commented Dec 18, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

@arthurschreiber arthurschreiber enabled auto-merge (squash) December 18, 2025 14:13
@arthurschreiber arthurschreiber merged commit 7631dac into main Dec 18, 2025
103 of 113 checks passed
@arthurschreiber arthurschreiber deleted the promptless/pr-19035-json-extract-dynamic-args branch December 18, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Evalengine changes to the evaluation engine Type: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants