evalengine: make JSON_EXTRACT work with non-static arguments
#19035
+164
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
arthurschreiber
force-pushed
the
arthur/fix-json-extract
branch
from
65ff0d1 to
4153731
Compare
Signed-off-by: Arthur Schreiber <[email protected]>
arthurschreiber
added
Component: Evalengine
arthurschreiber
commented
Dec 16, 2025
| regexp.MustCompile(`Illegal argument to a regular expression`), | ||
| regexp.MustCompile(`Incorrect arguments to regexp_substr`), | ||
| regexp.MustCompile(`Incorrect arguments to regexp_replace`), | ||
| regexp.MustCompile(`Invalid JSON path expression\. The error is around character position (\d+)\.`), |
Member
Author
There was a problem hiding this comment.
There's currently some differences in the error messages generated by the evalengine vs what MySQL generates when JSON Path parsing runs into issues.
For now, I'd like to ignore these differences - but I do believe we should be able to change our implementation in the future to mimic MySQL more closely.
Signed-off-by: Arthur Schreiber <[email protected]>
dbussink
approved these changes
Dec 16, 2025
Contributor
|
📝 Documentation updates detected! New suggestion: Add changelog entry for JSON_EXTRACT dynamic path arguments |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19035 +/- ##
==========================================
+ Coverage 69.81% 69.88% +0.06%
==========================================
Files 1610 1610
Lines 215362 215498 +136
==========================================
+ Hits 150358 150601 +243
+ Misses 65004 64897 -107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arthur Schreiber <[email protected]>
Member
Author
|
I had to push another fix for "static" but generated JSON Paths, like |
arthurschreiber
commented
Dec 16, 2025
Comment on lines
202
to
232
| yield(`JSON_EXTRACT('{"a": 1}', '$.a')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', '$.*')`, nil, false) | ||
| yield(`JSON_EXTRACT('[1, 2, 3]', '$[0 to 2]')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1, "b": 2}', '$.a', '$.b')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', '$.a', '$.z')`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT(CONCAT('{', '"a"', ':', ' ', '1', '}'), '$.a'))`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', CONCAT('$', '.', 'a'))`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT(NULL, '$.a')`, nil, false) | ||
| yield(`JSON_EXTRACT(NULL, NULL)`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT('{"a": 1}', NULL)`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', '$.a', NULL)`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', NULL, '$.a')`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT('{"a": 1}', '$.b')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', '$.b', '$.c')`, nil, false) | ||
| yield(`JSON_EXTRACT('[1,2,3]', '$[10]')`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT('{invalid}', '$.a')`, nil, false) | ||
| yield(`JSON_EXTRACT('not json', '$.a')`, nil, false) | ||
| yield(`JSON_EXTRACT('', '$.a')`, nil, false) | ||
| yield(`JSON_EXTRACT('{invalid}', NULL)`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT('{"a": 1}', '$.b[ 1 ].')`, nil, false) | ||
|
|
||
| yield(`JSON_EXTRACT(NULL, 'invalid-path')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', NULL, 'invalid-path')`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', 'invalid-path', NULL)`, nil, false) | ||
| yield(`JSON_EXTRACT('{"a": 1}', '$.a', 'invalid')`, nil, false) |
Member
Author
There was a problem hiding this comment.
Some of these could be handled by adding them to inputJSONObjects or inputJSONPaths, but that then highlights bugs in JSON_KEYS and JSON_CONTAINS, which I want to focus on in separate PRs.
nickvanw
approved these changes
Dec 16, 2025
nickvanw
reviewed
Dec 16, 2025
Signed-off-by: Arthur Schreiber <[email protected]>
Signed-off-by: Arthur Schreiber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiled
JSON_EXTRACTfunctions currently do not work when arguments are not static (e.g. bind variables or the result of another function call).This updates the compiler to handle non-static arguments, and also fixes null handling to match what MySQL is doing.
Static JSON path arguments are still optimized in the updated version, even when intermixed with non-static arguments.
Related Issue(s)
See #9647
Checklist
Deployment Notes
AI Disclosure