-
Notifications
You must be signed in to change notification settings - Fork 2.3k
release-23.0: Add version conditional for tablet missing error message
#19057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.0: Add version conditional for tablet missing error message
#19057
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
868a3aa to
fadda13
Compare
mattlord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.0 #19057 +/- ##
================================================
- Coverage 69.71% 69.69% -0.03%
================================================
Files 1606 1606
Lines 214584 214584
================================================
- Hits 149607 149555 -52
- Misses 64977 65029 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40aea57
into
vitessio:release-23.0
Description
This PR makes
release-23.0compatible with a forwards-incompatible change in v24, introduced in #19009Really only e2e tests should notice the incompatibility, which is just a change in the error message text
Related Issue(s)
#19009
Checklist
Deployment Notes
AI Disclosure