-
Notifications
You must be signed in to change notification settings - Fork 2.3k
evalengine: Fix NULL document handling in JSON functions
#19052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Arthur Schreiber <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
| if jp.ContainsWildcards() { | ||
| return ctype{}, errInvalidPathForTransform | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needed to be moved from here into the Fn_JSON_KEYS function to ensure the error here is only raised by JSON_KEYS in case the document is not-NULL. To do this, I moved the error handling into the compiled output.
Description
This aligns the
NULLhandling for thedocumentargument for allJSON_*functions to match the behavior of MySQL, and updates test to ensure this is being covered.Related Issue(s)
N/A
Checklist
Deployment Notes
AI Disclosure