-
Notifications
You must be signed in to change notification settings - Fork 2.3k
vtorc: add cell/location context
#19047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19047 +/- ##
==========================================
+ Coverage 69.88% 69.90% +0.02%
==========================================
Files 1610 1612 +2
Lines 215431 215815 +384
==========================================
+ Hits 150551 150863 +312
- Misses 64880 64952 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
| skippedRecoveriesMap := vars["SkippedRecoveries"].(map[string]interface{}) | ||
| skippedCount := GetIntFromValue(skippedRecoveriesMap[mapKey]) | ||
| assert.EqualValues(c, countExpected, skippedCount) | ||
| assert.GreaterOrEqual(c, skippedCount, countExpected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for flakiness. 1 or more is fine for this test - the important part is the ERS gets skipped
|
📝 Documentation updates detected! New suggestion: Document VTOrc --cell flag |
| --buffer-window duration Duration for how long a request should be buffered at most. (default 10s) | ||
| --catch-sigpipe catch and ignore SIGPIPE on stdout and stderr if specified | ||
| --cell string cell to use | ||
| --cell string cell to use (required) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated change to make it clear to users that VTGate requires this flag
|
📝 Documentation updates detected! New suggestion: Add changelog entry for VTOrc --cell flag |
Description
This PR adds to VTOrc the knowledge of what Vitess Cell a VTOrc process is running within. This knowledge will be used to gain confidence in certain VTOrc problems, by asking another cell to validate the detected problem
Today some problems (example
vttabletdown onPRIMARY) are not actioned by VTOrc, because it does not have enough confidence in it's detection from a single angle. On the opposite extreme, sometimes VTOrc believes it is correct using limited details, from only it's perspectiveThe topology recovery side of this change will come in future PRs, for now having this in v24 will be useful
Details:
--cellflag added to VTOrcvtgate) in v25+.StartVTOrc/.StartVTOrcs/etc signature (😞)examples/shell scripts updated for new flagRelated Issue(s)
Checklist
Deployment Notes
AI Disclosure