Skip to content

Conversation

@mcrauwel
Copy link
Contributor

Description

adding some extra documentation to the buffer window flag

Related Issue(s)

#19038

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

No AI was used :)

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 16, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 16, 2025
@promptless
Copy link
Contributor

promptless bot commented Dec 16, 2025

📝 Documentation updates detected!

New suggestion: Clarify buffer-window constraint documentation

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.88%. Comparing base (749fe54) to head (2fb14de).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19039   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files        1610     1610           
  Lines      215431   215504   +73     
=======================================
+ Hits       150551   150606   +55     
- Misses      64880    64898   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvaillancourt timvaillancourt added Type: Documentation Component: VTGate and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 17, 2025
@timvaillancourt
Copy link
Contributor

👋 @mcrauwel we also need an update to the flag e2e test here: https://github.com/vitessio/vitess/blob/main/go/flags/endtoend/vtgate.txt. Currently CI is failing

Signed-off-by: Matthias Crauwels <[email protected]>
Signed-off-by: Matthias Crauwels <[email protected]>
@timvaillancourt timvaillancourt self-requested a review December 17, 2025 16:54
@mattlord mattlord merged commit 1e90cfd into vitessio:main Dec 18, 2025
103 of 106 checks passed
@mattlord mattlord deleted the mcrauwel/vtgate-buffer-window-doc branch December 18, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants