-
Notifications
You must be signed in to change notification settings - Fork 2.3k
add extra documentation for buffer_window flag
#19039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extra documentation for buffer_window flag
#19039
Conversation
Signed-off-by: Matthias Crauwels <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
|
📝 Documentation updates detected! New suggestion: Clarify buffer-window constraint documentation |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19039 +/- ##
=======================================
Coverage 69.88% 69.88%
=======================================
Files 1610 1610
Lines 215431 215504 +73
=======================================
+ Hits 150551 150606 +55
- Misses 64880 64898 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
👋 @mcrauwel we also need an update to the flag e2e test here: https://github.com/vitessio/vitess/blob/main/go/flags/endtoend/vtgate.txt. Currently CI is failing |
Signed-off-by: Matthias Crauwels <[email protected]>
Signed-off-by: Matthias Crauwels <[email protected]>
Description
adding some extra documentation to the buffer window flag
Related Issue(s)
#19038
Checklist
Deployment Notes
AI Disclosure
No AI was used :)