Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Dec 16, 2025

Documents PR #19009, which adds a new tablet_shutdown_time field to the Tablet protobuf and validates tablet records before connection attempts. This reduces unnecessary connection attempts to shutdown tablets and eliminates log noise from failed connections to invalid addresses.

Trigger Events

Open this suggestion in the Promptless dashboard


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 16, 2025
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 16, 2025
@promptless
Copy link
Contributor Author

promptless bot commented Dec 16, 2025

🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them.

@timvaillancourt timvaillancourt added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: General Changes throughout the code base Type: Documentation Component: Documentation docs related issues/PRs and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 16, 2025
@timvaillancourt timvaillancourt marked this pull request as ready for review December 16, 2025 15:09
@promptless
Copy link
Contributor Author

promptless bot commented Dec 16, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

I've investigated the CI failure on PR #19037. The check is failing because the PR needs a component label that reflects the code changes being documented.

Since this PR documents tablet shutdown tracking and connection validation features, please add the "Component: Cluster management" label to the PR. This should resolve the CI check failure.

(I'm unable to add labels directly as my GitHub access is read-only.)

@promptless
Copy link
Contributor Author

promptless bot commented Dec 16, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

@timvaillancourt timvaillancourt merged commit 865a7b3 into main Dec 17, 2025
108 of 115 checks passed
@timvaillancourt timvaillancourt deleted the promptless/pr-19009-tablet-shutdown-validation branch December 17, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation docs related issues/PRs Component: General Changes throughout the code base Type: Documentation Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants