-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: Add changelog entry for tablet shutdown tracking and validation #19037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add changelog entry for tablet shutdown tracking and validation #19037
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
|
🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them. |
|
Promptless escalated the following message to you. If you respond, please remember to tag Promptless: I've investigated the CI failure on PR #19037. The check is failing because the PR needs a component label that reflects the code changes being documented. Since this PR documents tablet shutdown tracking and connection validation features, please add the "Component: Cluster management" label to the PR. This should resolve the CI check failure. (I'm unable to add labels directly as my GitHub access is read-only.) |
|
Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.) |
Documents PR #19009, which adds a new
tablet_shutdown_timefield to the Tablet protobuf and validates tablet records before connection attempts. This reduces unnecessary connection attempts to shutdown tablets and eliminates log noise from failed connections to invalid addresses.Trigger Events
grpctmclient: validate tablet record on dialOpen this suggestion in the Promptless dashboard
Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.
If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)