Skip to content

Conversation

@promptless
Copy link
Contributor

@promptless promptless bot commented Dec 16, 2025

Documents PR #18740, which adds four new observability metrics to VTTablet's QueryThrottler. The metrics track total requests evaluated, throttled requests, total latency, and evaluation latency. Each metric includes labels for Strategy, Workload, and Priority, with the throttled metric providing additional context about which metric triggered throttling and whether it was in dry-run mode.

Trigger Events

Open this suggestion in the Promptless dashboard


Help us improve Promptless — If this suggestion missed the mark, please share quick feedback.

If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Dec 16, 2025
@promptless
Copy link
Contributor Author

promptless bot commented Dec 16, 2025

🔧 I noticed that some CI checks failed for this PR. I'm investigating the failures and will work on fixing them.

@github-actions github-actions bot added this to the v24.0.0 milestone Dec 16, 2025
@promptless
Copy link
Contributor Author

promptless bot commented Dec 16, 2025

Promptless escalated the following message to you. If you respond, please remember to tag Promptless:

The CI check failed because the PR is missing required labels. All PRs in the vitessio/vitess repository must have:

  1. A Type: label
  2. A Component: label

For this changelog documentation PR, you'll need to add:

  • Type: Documentation
  • Component: VTTablet (recommended, since QueryThrottler is a VTTablet feature)

You can add these labels through the GitHub UI by clicking the gear icon next to "Labels" in the right sidebar of the PR page.

Once the labels are added, the CI check should pass automatically.

@mattlord mattlord added Component: Query Serving Type: Release and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants