-
Notifications
You must be signed in to change notification settings - Fork 2.3k
vstreamer: improve error message when table not found due to keyspace… #18961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
varundeepsaini
wants to merge
1
commit into
vitessio:main
Choose a base branch
from
varundeepsaini:fix-vstreamer-error-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
vstreamer: improve error message when table not found due to keyspace… #18961
varundeepsaini
wants to merge
1
commit into
vitessio:main
from
varundeepsaini:fix-vstreamer-error-message
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
e3c5168 to
3229fbf
Compare
… vindex errors Signed-off-by: Varun Deep Saini <[email protected]>
3229fbf to
3025a04
Compare
Author
|
@mattlord I think my changes aren't interfering with the tests. Can you re-run the failed checks? |
mattlord
approved these changes
Dec 17, 2025
Member
|
Thanks, @varundeepsaini ! ❤️ |
Author
|
@rohit-nayak-ps could you please approve and merge this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves error message when VReplication fails to find a table due to keyspace vindex errors. Previously, if a
region_jsonvindex failed to load its config file (not mounted on vttablet), users saw only "table customer not found". Now the underlying error is included:table customer not found in keyspace main (keyspace has error: open /path/to/file: no such file or directory).Related Issue(s)
Fixes #18247
Checklist
Deployment Notes
None - error message improvement only.
AI Disclosure
Tests were written by Claude