-
Notifications
You must be signed in to change notification settings - Fork 2.3k
vtorc: add Reason and missing cases to SkippedRecoveries metric
#18644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtorc: add Reason and missing cases to SkippedRecoveries metric
#18644
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18644 +/- ##
==========================================
- Coverage 67.52% 67.50% -0.02%
==========================================
Files 1608 1608
Lines 263611 263612 +1
==========================================
- Hits 177994 177958 -36
- Misses 85617 85654 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
…Recoveries-metric Signed-off-by: Tim Vaillancourt <[email protected]>
…Recoveries-metric Signed-off-by: Tim Vaillancourt <[email protected]>
mattlord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just had the one basic question about managing the labels. Let me know if I'm just missing or misunderstanding something. I can come back to this quickly either way.
Description
This PR extends the VTOrc
SkippedRecoveriescounter-metric by adding aReasonfield and some missing casesThis metric was recently introduced in #17985 and no releases have occurred since
Related Issue(s)
Resolves #18645
Checklist
Deployment Notes