Skip to content

Store Message as a Shared Constant Char Array #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
threeal merged 4 commits into from
Dec 27, 2023
Merged

Store Message as a Shared Constant Char Array #108

threeal merged 4 commits into from
Dec 27, 2023

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Dec 27, 2023 •
edited
Loading

This pull request resolves #100 by modifying the error message from being stored as std::shared_ptr<const std::string> to be stored as std::shared_ptr<const char[]>.

It also renames the error message variable to msg_ptr and modifies the msg parameter in the errors::make function to use std::string_view.

@threeal threeal self-assigned this Dec 27, 2023
@threeal threeal marked this pull request as ready for review December 27, 2023 10:04
@threeal threeal merged commit 09b61b7 into main Dec 27, 2023
@threeal threeal deleted the store-msg-shared-char-array branch December 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@threeal threeal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Store Message as a Shared Constant Char Array

2 participants

@threeal