Skip to content

Error: Create Error Object with {fmt} #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
threeal merged 2 commits into from
Jun 22, 2023
Merged

Error: Create Error Object with {fmt} #10

threeal merged 2 commits into from
Jun 22, 2023

Conversation

@threeal
Copy link
Owner

@threeal threeal commented Jun 22, 2023 •
edited
Loading

Modified the Error struct with the following changes:

  • Changed the message member to be stored as std::string instead of const char*.
  • Updated the constructor to support string formatting using the {fmt} library.

Closes #8.

@threeal threeal added the feat label Jun 22, 2023
@threeal threeal self-assigned this Jun 22, 2023
@threeal threeal marked this pull request as ready for review June 22, 2023 06:30
@threeal threeal merged commit 7af81f1 into main Jun 22, 2023
@threeal threeal deleted the error-format branch June 22, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@threeal threeal

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Create Error Object with {fmt}

2 participants

@threeal