Implement Zip::all() #615
Merged
Implement Zip::all() #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test if every element of the iterator matches a predicate. This is useful, for instance, to test if two matrices are elementwise "similar" (within a given threshold) without modifying the matrices.
jturner314
reviewed
Apr 11, 2019
Member
jturner314
left a comment
jturner314
left a comment
There was a problem hiding this comment.
This looks useful. I've added a couple of comments. It would be nice to add an .any() method too, but that doesn't have to be part of this PR.
Member
|
Once this is merged, I'll rewrite #581 in terms of |
jturner314
approved these changes
Apr 19, 2019
Member
jturner314
left a comment
jturner314
left a comment
There was a problem hiding this comment.
Looks good to me. I'll wait a little while for comments from anyone else and then merge this.
Member
|
Happy to merge this @jturner314 👍 |
Member
|
@LukeMathWalker Sure, please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if every element of the iterator matches a predicate.
This is useful, for instance, to test if two matrices are elementwise
"similar" (within a given threshold) without modifying the matrices.false