replace match on unchecked_sub with unwrap_or_default #150262
+6
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
rust-cloud-vms
bot
force-pushed
the
slice-iter-2
branch
from
6fbdca3 to
0fda856
Compare
Kivooeo
approved these changes
Dec 22, 2025
KonaeAkira
reviewed
Dec 23, 2025
library/core/src/slice/iter.rs
Outdated
| Some(sum) => sum, | ||
| None => 0, | ||
| }; | ||
| let start = end.checked_sub(self.chunk_size).unwrap_or_default(); |
Contributor
There was a problem hiding this comment.
Suggested change
| let start = end.checked_sub(self.chunk_size).unwrap_or_default(); | |
| let start = end.saturating_sub(self.chunk_size); |
wouldn't this be even better?
Member
Author
There was a problem hiding this comment.
Yes, that's correct, and I'm now using that.
rust-cloud-vms
bot
force-pushed
the
slice-iter-2
branch
from
0fda856 to
fd29ce0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
slice-iter-2
branch
from
fd29ce0 to
16b219a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #146436
r? @joboet