[ruby/net-http] Use nonblocking IO to detect eof #6423
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
force-pushed
the
http_eof_tls13
branch
from
06b76be to
f9ab934
Compare
The call to `@socket.eof?` can block when attempting to reuse a persistent connection and there are SSL Handshake messages ready to be read, but no Application Data, such as when the server sends an updated NewSessionTicket in TLS 1.3. Instead call `OpenSSL::SSL::SSLSocket#read_nonblocking`, which will read and process the SSL Handshake message, but return `nil` on EOF or an empty string if no data is available. It may also return `:wait_readable` or `:wait_writable` which indicates the socket is reusable.
joshcooper
force-pushed
the
http_eof_tls13
branch
from
f9ab934 to
a044045
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
@socket.eof?can block when attempting to reuse a persistent connection and there are SSL Handshake messages ready to be read, but no Application Data, such as when the server sends an updated NewSessionTicket in TLS 1.3.Instead call
OpenSSL::SSL::SSLSocket#read_nonblocking, which will read and process the SSL Handshake message, but returnnilon EOF or an empty string if no data is available. It may also return:wait_readableor:wait_writablewhich indicates the socket is reusable.Filed as https://bugs.ruby-lang.org/issues/19017