JSON::Ext::Parser mark the name cache entries when not on the heap #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is somewhat dead code as unless you are using `JSON::Parser.new` direcltly we never allocate `JSON::Ext::Parser` anymore. But still, we should mark all its reference in case some code out there uses that. Followup: ruby#675
byroot
force-pushed
the
mark-name-cache
branch
from
7aaa316 to
8bf74a9
Compare
byroot
commented
Nov 3, 2024
| # frozen_string_literal: true | ||
| require 'mkmf' | ||
|
|
||
| have_func("rb_enc_raise", "ruby.h") |
Member
Author
There was a problem hiding this comment.
All rubies have this now, I haven't check exactly when it was added, but I suspect this was for pre-1.9 rubies.
byroot
commented
Nov 3, 2024
| rb_gc_mark(json->decimal_class); | ||
| rb_gc_mark(json->match_string); | ||
| const VALUE *name_cache_entries = &json->name_cache.entries[0]; | ||
| rb_gc_mark_locations(name_cache_entries, name_cache_entries + json->name_cache.length); |
Member
Author
There was a problem hiding this comment.
dyld[4099]: missing symbol called
cc @eregon looks like rb_gc_mark_locations is also missing on Truffle?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat dead code as unless you are using
JSON::Parser.newdirecltly we never allocateJSON::Ext::Parseranymore.But still, we should mark all its reference in case some code out there uses that.
Followup: #675