Skip to content

Jsx in depth #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lex111 merged 6 commits into from
Mar 5, 2019
Merged

Jsx in depth #206

lex111 merged 6 commits into from
Mar 5, 2019

Conversation

@RenatRysaev
Copy link
Contributor

@RenatRysaev RenatRysaev commented Mar 1, 2019

No description provided.

@netlify
Copy link

netlify bot commented Mar 1, 2019 •
edited
Loading

Deploy preview for ru-reactjs ready!

Built with commit 876fafc

https://deploy-preview-206--ru-reactjs.netlify.com

@RenatRysaev RenatRysaev mentioned this pull request Mar 1, 2019
Closed
88 tasks
@gcor gcor added the needs review A pull request ready to be reviewed label Mar 1, 2019
angryermine
angryermine reviewed Mar 1, 2019
View reviewed changes
ntishkevich
ntishkevich reviewed Mar 1, 2019
View reviewed changes
lex111
lex111 reviewed Mar 1, 2019
View reviewed changes
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложения для улучшения перевода.

another-guy
another-guy requested changes Mar 2, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Перевод хороший. Я постарался убрать повторяющиеся слова и частые вводные конструкции. Местами мелкие опечатки и пунктуационные неточности.

@RenatRysaev спасибо за работу над очередным переводом !!! 👍

@another-guy another-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Mar 2, 2019
gcor
gcor reviewed Mar 3, 2019
View reviewed changes
gcor
gcor reviewed Mar 3, 2019
View reviewed changes
gcor
gcor reviewed Mar 3, 2019
View reviewed changes
Copy link
Collaborator

@gcor gcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Попробовал упростить некоторые места

another-guy
another-guy approved these changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcor спасибо за дополнительный проход по тексту!

ntishkevich
ntishkevich reviewed Mar 4, 2019
View reviewed changes
@lex111
Copy link
Member

lex111 commented Mar 4, 2019

@RenatRysaev вы можете, пожалуйста, принять предложенные правки?

@RenatRysaev
Copy link
Contributor Author

RenatRysaev commented Mar 5, 2019

@RenatRysaev вы можете, пожалуйста, принять предложенные правки?

@lex111, да, сегодня закомичу

@lex111 lex111 merged commit e0876b4 into reactjs:master Mar 5, 2019
@lex111
Copy link
Member

lex111 commented Mar 5, 2019

Спасибо @RenatRysaev за перевод, а также @lfedorov, @ntishkevich, @another-guy и @gcor за ревью!

P.S. Внёс свои корректировки, в основном перевод в примерах кода.

@lex111 lex111 added needs proofread A read-through is still needed to release the document and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcor gcor gcor left review comments

@another-guy another-guy another-guy approved these changes

@ntishkevich ntishkevich ntishkevich left review comments

@lex111 lex111 lex111 approved these changes

+1 more reviewer

@angryermine angryermine angryermine left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs proofread A read-through is still needed to release the document

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@RenatRysaev @lex111 @angryermine @gcor @another-guy @ntishkevich