Skip to content

Conversation

@smikitky
Copy link
Member

@smikitky smikitky commented Feb 3, 2019

This is the second chapter of Hooks documentation.

「早わかり」という訳がちょっとアレかもしれないのですがそこはご意見をお待ちしています

@smikitky smikitky requested a review from potato4d February 3, 2019 01:17
@tesseralis tesseralis mentioned this pull request Feb 3, 2019
90 tasks
@koba04 koba04 self-requested a review February 4, 2019 01:16
Copy link
Contributor

@sasurau4 sasurau4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました 🙏

@koba04 koba04 removed their request for review February 4, 2019 09:40
@koba04 koba04 self-requested a review February 4, 2019 14:59
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい点ですが、いくつかコメントしましたので確認お願いします。

@smikitky
Copy link
Member Author

smikitky commented Feb 5, 2019

@koba04 全部対応しました、ありがとうございました!

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございました!

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

#91 でフックに関わる差分がマージされます。翻訳を修正するまでマージはお待ちください。

@smikitky
Copy link
Member Author

smikitky commented Feb 7, 2019

#91 の差分のマージを終えました

@smikitky
Copy link
Member Author

見出しID修正が取り込まれていなかったので rebase & force-push しました。

@potato4d どうでしょう?

@potato4d
Copy link
Member

明日の朝見ます 🙇

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

@smikitky smikitky merged commit e5fe12e into master Feb 13, 2019
@smikitky smikitky deleted the tr/hooks-overview branch February 13, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants