Skip to content

Translate testing #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koba04 merged 13 commits into from
Sep 4, 2019
Merged

Translate testing #241

koba04 merged 13 commits into from
Sep 4, 2019

Conversation

@taneba
Copy link
Contributor

@taneba taneba commented Aug 30, 2019

This PR is part of #4
1/3 of testing docs

@netlify
Copy link

netlify bot commented Aug 30, 2019

Deploy preview for ja-reactjs ready!

Built with commit d82508c

https://deploy-preview-241--ja-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Aug 30, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit 1e547d1

https://deploy-preview-241--ja-reactjs.netlify.com

potato4d
potato4d reviewed Sep 1, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました〜。

potato4d
potato4d approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ありがとうございました！

koba04
koba04 reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
翻訳ありがとうございます！！
細かい言い回しの修正ばかりですがコメントしたので確認お願いします 🙇

taneba and others added 8 commits September 4, 2019 11:42
@taneba @koba04
Update content/docs/testing.md
36a344e 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
b6a5007 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
b581f26 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
1fef1b0 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
0ae1541 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
eca5968 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
a4e63df 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
0b42aed 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba
Copy link
Contributor Author

taneba commented Sep 4, 2019

@koba04
レビューありがとうございました！
２点コメント返しましたのでご確認お願いします 🙇

taneba and others added 2 commits September 4, 2019 13:54
@taneba @koba04
Update content/docs/testing.md
299278d 
Co-Authored-By: Toru Kobayashi <[email protected]>
@taneba @koba04
Update content/docs/testing.md
05bd182 
Co-Authored-By: Toru Kobayashi <[email protected]>
koba04
koba04 reviewed Sep 4, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taneba
すみません、suggestionsの内容が古いようでした。
@taneba さんの翻訳に近い形に戻したものが本来提案したかったものなので改めて確認お願いします。
お手数お掛けしてすみません 🙇

こちらでApproveにしたいと思います。

@taneba @koba04
Update content/docs/testing.md
1e547d1 
Co-Authored-By: Toru Kobayashi <[email protected]>
koba04
koba04 approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 対応ありがとうございました！！

@koba04 koba04 merged commit 6c9b55c into reactjs:master Sep 4, 2019
@tesseralis tesseralis mentioned this pull request Sep 4, 2019
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koba04 koba04 koba04 approved these changes

@potato4d potato4d potato4d approved these changes

@smikitky smikitky Awaiting requested review from smikitky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taneba @koba04 @potato4d