docs(iOS): update docs for animationDuration #12747
Conversation
|
Hey @kmichalikk! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
satya164
force-pushed
the
@kmichalikk/animation-duration-transparent-modal-docs
branch
from
65bfdf2 to
5634ed1
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12747 +/- ##
==========================================
+ Coverage 74.13% 74.39% +0.26%
==========================================
Files 223 225 +2
Lines 7295 7448 +153
Branches 2906 2992 +86
==========================================
+ Hits 5408 5541 +133
- Misses 1832 1853 +21
+ Partials 55 54 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189. **Motivation** In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for `transitionDuration` to reflect that we don't support customizing it for modals. This PR adds matching change to `animationDuration` doc. --------- Co-authored-by: Satyajit Sahoo <[email protected]>
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189. **Motivation** In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for `transitionDuration` to reflect that we don't support customizing it for modals. This PR adds matching change to `animationDuration` doc. --------- Co-authored-by: Satyajit Sahoo <[email protected]>
3 participants
Docs update to match changes in react-native-screens software-mansion/react-native-screens#3189.
Motivation
In RN Screens, we fixed the bug with delay when dismissing full screen modals, and updated the docs for
transitionDurationto reflect that we don't support customizing it for modals. This PR adds matching change toanimationDurationdoc.