Enable HiDPI scaling on Windows by default #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushfoo
changed the title
Member
|
I can't test this at the moment, but I don't see a reason not to merge it. @DragonMoffon or @DigiDuncan, can you try it on one of your systems? |
Member
Author
|
Collaborator
|
Pyglet dev6 just released if we want to look into this again |
Member
|
I finished #2385:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should obey the UI scaling on windows by default. This is supported in pyglet 2.1. Users with 4k screens no longer need to look at a postage stamp of a window.
It looks like the scaling in pyglet doesn't work like on MacOS/retina were the window size stays unchanged. Only framebuffer size increases and you get a pixel ratio between them. The plan in pyglet is to support two modes:
Related issue: pyglet/pyglet#1202