-
Notifications
You must be signed in to change notification settings - Fork 361
Pyglet2.1dev$VERSION updates #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e42f0d0 to
4a1291c
Compare
7588b63 to
30d473e
Compare
* Use new-style | None * Add casting and TODO on resolving screen coord issues upstream * Mention rounding issue in set_fullscreen
* Update top-level docstring * Update bold setter & getter * Update bold return types
* Use development pyglet in rolling release mode + comment it * Add commented-out future pyglet == 2.1dev4 release we can swap to it later
* Centralize headless * Add some type: ignore since pyglet did vague .pyi
This reverts commit c59d674.
30d473e to
5056d91
Compare
The class is dynamically assigned at runtime so pyright can't handle it.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #2183 (same contents, just a branch on the main Arcade repo)
Big changes:
pyglet.optionsobject appropriately__eq__deletion tricksOther changes:
pyright's spec-violating ideas o onLiteralfor text| Nonein a few placesfloatvsintfor window sizes (Apple supports these, apparently to simplify touch events)To resolve:
(moved to #2278 + will move to sub-issues as needed)