Skip to content

bpo-46424: cover Annotation[int] invalid usage in tests #30663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fidget-Spinner merged 1 commit into from
Jan 18, 2022
Merged

bpo-46424: cover Annotation[int] invalid usage in tests #30663

Fidget-Spinner merged 1 commit into from
Jan 18, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 18, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 18, 2022
@Fidget-Spinner Fidget-Spinner merged commit 3239829 into python:main Jan 18, 2022
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Jan 19, 2022

@sobolevn could you do me a favour please and mark any of your typing tests PRs as needs backport to x.x? I will review and merge them for you. My motivation follows:

  • Easier to handle future bugfix backports.
  • Properly test older versions of Python, so that bugfix backports don't accidentally break things.

Thanks for your time!

@miss-islington
Copy link
Contributor

miss-islington commented Jan 19, 2022

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jan 19, 2022

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented Jan 19, 2022

Sorry @sobolevn and @Fidget-Spinner, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 32398294fb3fcf4ee74da54722fd0221c4e6cb74 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 19, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jan 19, 2022

GH-30691 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
@sobolevn @miss-islington
bpo-46424: [typing] cover Annotation[arg] invalid usage in tests (p…
4b8b369 
…ythonGH-30663)

(cherry picked from commit 3239829)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Jan 19, 2022

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jan 19, 2022

GH-30692 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 19, 2022
@sobolevn @miss-islington
bpo-46424: [typing] cover Annotation[arg] invalid usage in tests (p…
30b0b05 
…ythonGH-30663)

(cherry picked from commit 3239829)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Jan 19, 2022
@miss-islington @sobolevn
bpo-46424: [typing] cover Annotation[arg] invalid usage in tests (G…
baf26d0 
…H-30663)

(cherry picked from commit 3239829)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Jan 19, 2022
@miss-islington @sobolevn
[3.9] bpo-46424: [typing] cover Annotation[arg] invalid usage in te…
331378d 
…sts (GH-30663) (GH-30692)

(cherry picked from commit 3239829)


Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
Copy link
Member Author

sobolevn commented Jan 19, 2022

@Fidget-Spinner sure thing, will do in the future!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @sobolevn @hello-adam
[3.9] bpo-46424: [typing] cover Annotation[arg] invalid usage in te…
242946e 
…sts (pythonGH-30663) (pythonGH-30692)

(cherry picked from commit 3239829)


Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@Fidget-Spinner Fidget-Spinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn @Fidget-Spinner @miss-islington @bedevere-bot @hugovk @the-knights-who-say-ni