gh-143241: Fix infinite loop in zoneinfo._common.load_data #143243
Merged
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
approved these changes
Dec 28, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Please add a NEWS entry, users will be glad to know that that bug was fixed.
I would not call it a DoS.
fatihhcelik
changed the title
picnixz
reviewed
Dec 28, 2025
picnixz
reviewed
Dec 28, 2025
Misc/NEWS.d/next/Library/2025-12-28-12-38-53.gh-issue-143241.yW250u.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Dec 28, 2025
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Dec 28, 2025
picnixz
reviewed
Dec 28, 2025
Remove unnecessary tz_bytes variable. Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Dec 28, 2025
Misc/NEWS.d/next/Library/2025-12-28-13-49-06.gh-issue-143241.5H4b8d.rst
Outdated
Show resolved
Hide resolved
…H4b8d.rst Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
approved these changes
Dec 28, 2025
Member
|
I'm going to wait for the CI to be green and then I'll merge. |
|
Thanks @fatihhcelik for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 28, 2025
…ythonGH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 28, 2025
…ythonGH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-143251 is a backport of this pull request to the 3.14 branch. |
|
GH-143252 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Dec 28, 2025
…H-143243) (#143252) gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
added a commit
that referenced
this pull request
Dec 28, 2025
…H-143243) (#143251) gh-143241: Fix infinite loop in `zoneinfo._common.load_data` (GH-143243) Correctly reject truncated TZif files in `ZoneInfo.from_file`. --------- (cherry picked from commit 3ca1f2a) Co-authored-by: Fatih Çelik <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoneinfo._common.load_data#143241