Add progress bar tokens #1242
Merged
Add progress bar tokens #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a4c52b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Design Token Diff (CSS)
|
Contributor
Design Token Diff (StyleLint)The message is too long to be displayed here. For more details, please check the job summary. |
Contributor
Design Token Diff (Figma)The message is too long to be displayed here. For more details, please check the job summary. |
github-actions
bot
removed
the
update snapshots
github-actions
bot
removed
the
update snapshots
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds new design tokens for progress bar components to support high contrast themes. The implementation provides specific color overrides for various theme variants while maintaining backwards compatibility with existing designs.
- Introduces comprehensive progress bar tokens with track background/border colors and semantic item colors
- Implements high contrast theme support with specific color overrides for accessibility
- Adds changeset documentation for the new feature
Reviewed Changes
Copilot reviewed 2 out of 134 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tokens/component/progressBar.json5 | Defines complete progress bar token structure with track styling and semantic color variants |
| .changeset/beige-pets-lie.md | Documents the minor version change for the new progress bar tokens |
| 'dark-high-contrast': '{progressBar.track.bgColor}', | ||
| 'dark-dimmed-high-contrast': '{progressBar.track.bgColor}', | ||
| 'dark-protanopia-deuteranopia-high-contrast': '{progressBar.track.bgColor}', | ||
| 'dark-tritanopia-high-contrast': '{progressBar.track.bgColor}', |
There was a problem hiding this comment.
These circular references create a dependency loop where progressBar.track.borderColor references progressBar.track.bgColor, but progressBar.track.bgColor itself has overrides that could potentially reference back. Consider using direct base color tokens instead of self-referential tokens to avoid potential resolution issues.
Suggested change
| 'dark-tritanopia-high-contrast': '{progressBar.track.bgColor}', | |
| 'dark-high-contrast': '{bgColor.inverse}', | |
| 'dark-dimmed-high-contrast': '{bgColor.inverse}', | |
| 'dark-protanopia-deuteranopia-high-contrast': '{bgColor.inverse}', | |
| 'dark-tritanopia-high-contrast': '{bgColor.inverse}', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
progressBartokens to support high contrast themes. Default themes will respect the existing design, while high contrast themes will include custom item colors and an overall track outline.Check out Primer React for a visual: https://primer-6385406b5d-13348165.drafts.github.io/storybook/?path=/story/components-progressbar-features--all-colors&globals=colorScheme:all