Remember function return type extensions

[staabm]

before this PR:

➜  phpstan-src git:(2.1.x) ✗ PHPSTAN_GNSR=1 hyperfine 'php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php' --runs=5
Benchmark 1: php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php
  Time (mean ± σ):     15.219 s ±  0.105 s    [User: 14.850 s, System: 0.359 s]
  Range (min … max):   15.059 s … 15.339 s    5 runs

---

after this PR:

➜  phpstan-src git:(remember-fns) ✗ PHPSTAN_GNSR=1 hyperfine 'php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php' --runs=5
Benchmark 1: php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php
  Time (mean ± σ):     15.049 s ±  0.230 s    [User: 14.679 s, System: 0.360 s]
  Range (min … max):   14.659 s … 15.264 s    5 runs

[staabm]

interessting.. I don't see this errors locally.. will have another look

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

I'd say this line doesn't have to use ??= because of isset above. It should just be =.

[staabm]

good catch, fixed

[staabm]

btw: including this PR and the most recent 10 commits we got considerable faster with the recent changes:

before

➜  hyperfine 'php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php' --runs=5
Benchmark 1: php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php
  Time (mean ± σ):     14.478 s ±  0.134 s    [User: 14.118 s, System: 0.353 s]
  Range (min … max):   14.316 s … 14.669 s    5 runs

now

➜  hyperfine 'php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php' --runs=5
Benchmark 1: php vendor/bin/phpunit tests/PHPStan/Analyser/NodeScopeResolverTest.php
  Time (mean ± σ):     13.764 s ±  0.135 s    [User: 13.423 s, System: 0.334 s]
  Range (min … max):   13.642 s … 13.974 s    5 runs

[ondrejmirtes]

Yeah, great, thank you! A similar thing could be done for methods+static methods.