doc: add missing passed and error properties on TestContext
#61185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Xstoudi
force-pushed
the
doc/test-context-missing-props
branch
2 times, most recently
from
51ed148 to
dbb7ac8
Compare
Contributor
Author
|
Also added |
avivkeller
requested changes
Dec 28, 2025
Member
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
Thank you! Unfortunately, there are some things that need to be corrected before this can land
Member
|
Additionally, please list the original author as a Co-Author |
`passed` and `error` properties were left undocumented on `TextContext` class Fixes: nodejs#59321 Refs: nodejs#51485 Refs: nodejs#59322 Co-authored-by: SimonSchick <[email protected]>
Xstoudi
force-pushed
the
doc/test-context-missing-props
branch
from
dbb7ac8 to
53458bd
Compare
Contributor
Author
|
done, thanks for the review |
avivkeller
approved these changes
Dec 28, 2025
avivkeller
added
the
commit-queue-squash
atlowChemi
approved these changes
Dec 28, 2025
cjihrig
approved these changes
Dec 28, 2025
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 20bf328 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passedanderrorproperties were left undocumented onTextContextclassFixes: #59321
Refs: #51485 <-- passed and error implem
Refs: #59322 <-- Initial PR
PR was already made by someone else but closed prematurely even if valid, see second ref.
I removed this part, which seems wrong because I tested it and even
Errorinstances end up wrapped: