src: fix JSError inspection #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Still need to add the metadata to V8 before landing this. |
mmarchini
changed the title
Member
|
Is there an estimate of the time the V8 patch will land in Node? |
Contributor
Author
|
Since the patch landed on V8 6.9, I'll open backport PRs to all relevant Node.js Release lines (v8.x and v10.x). |
Contributor
Author
|
Backport landed on core master: nodejs/node#21855 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
CI should be green (except for #209) after the next v8.x release. |
mmarchini
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
added 2 commits
September 11, 2018 09:44
This commit fixes JSError inspection for Node.js v7+. We still need to figure out a way to get the stack from the Error object though. Ref: nodejs#143
Contributor
Author
|
Landed in 816c46c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes JSError inspection for Node.js v7+. We still need to
figure out a way to get the stack from the Error object though.
Ref: #143