Skip to content

feat: support co-authorship lines in body #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakobJingleheimer wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: support co-authorship lines in body #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37e4e88
feat: support co-authorship lines in body
JakobJingleheimer Dec 9, 2025
f1496de
fixup!: apply case-insensitive suggestion
JakobJingleheimer Dec 22, 2025
f778e67
fixup!: account for optional leading whitespace
JakobJingleheimer Dec 22, 2025
5004df9
test: add case for long co-author line
JakobJingleheimer Dec 22, 2025
d7c76aa
fixup!: de-lint
JakobJingleheimer Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/rules/line-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,14 @@ export default {
let failed = false
for (let i = 0; i < parsed.body.length; i++) {
const line = parsed.body[i]

// Skip quoted lines, e.g. for original commit messages of V8 backports.
if (line.startsWith(' ')) { continue }
// Skip lines with URLs.
if (/https?:\/\//.test(line)) { continue }
// Skip co-authorship.
if (/^\s*Co-authored-by:/i.test(line)) { continue }
Copy link
Contributor

@aduh95 aduh95 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to allow prefixing with whitespaces, those are not recognized by git

Suggested change
if (/^\s*Co-authored-by:/i.test(line)) { continue }
if (/^co-authored-by:/i.test(line)) { continue } 
git interpret-trailers --parse <<'EOF'
        fixup!: apply case-insensitive suggestion
        Co-authored-by: Michaël Zasso <[email protected]>
EOF

Copy link
Member Author

@JakobJingleheimer JakobJingleheimer Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing co-author rule uses that. I think we should keep it consistent and then fix them together (on their own).


if (line.length > len) {
failed = true
context.report({
Expand Down
30 changes: 30 additions & 0 deletions test/rules/line-length.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,5 +129,35 @@ https://${'very-'.repeat(80)}-long-url.org/
tt.end()
})

t.test('Co-author lines', (tt) => {
const v = new Validator()
const context = new Commit({
sha: 'f1496de5a7d5474e39eafaafe6f79befe5883a5b',
author: {
name: 'Jacob Smith',
email: '[email protected]',
date: '2025-12-22T09:40:42Z'
},
message: `
fixup!: apply case-insensitive suggestion
Co-authored-by: Michaël Zasso <[email protected]>
`
}, v)

context.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, '', 'string')
tt.equal(opts.level, 'pass', 'level')
}

Rule.validate(context, {
options: {
length: 72
}
})
tt.end()
})

t.end()
})