Use elipses for reverse mapped types in nested positions #28494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
DanielRosenwasser,
sandersn and
sheetalkamat
sheetalkamat
approved these changes
Nov 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't fix #23897 per sey, but makes it more apparent that we're eliding information in quickinfo (and not typechecking things wrong).
This is similar to the change I made in #28490 to make self-recursion locations print as
...instead ofany.There's still the issue of declaration emit for these types and such (and that today they emit as
anywithout being an error) - having some way to alias a reverse mapped type in general would go a long way towards making these print better, I think.