This repository was archived by the owner on Nov 1, 2017. It is now read-only.
Support task lists within block quotes #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Contributor
There was a problem hiding this comment.
I think that should be \s*. >>> works to create a three-deep blockquote.
Contributor
Author
|
Member
There was a problem hiding this comment.
Technically this stanza should be optional prefix; and item indicator would need to be clarified as list item indicator.
mtodd
added a commit
that referenced
this pull request
Sep 16, 2014
Support task lists within block quotes
Contributor
Author
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task lists within block quotes did not work correctly because the regular expression used to match an item with its place in the GFM form did not recognize items within blockquotes.
These changes close #31 by updating
itemPatternto recognize a task list item nested within an arbitrary level of block quoting.📣 @github/js @mtodd