set index-url from url #1522
Merged
set index-url from url #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to automatically set the index-url field from the url field for Python index credentials when index-url is not explicitly provided. This ensures consistent credential handling for Python package repositories.
- Adds a new private method
setIndexUrlFromUrlto handle the URL-to-index-url conversion logic - Integrates the new method into the credential processing workflow
- Includes comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/updater.ts | Adds setIndexUrlFromUrl method and integrates it into credential processing |
| tests/updater.test.ts | Adds test case to verify index-url is set from url for Python credentials |
Comments suppressed due to low confidence (1)
tests/updater.test.ts:250
- The test creates an Updater instance but doesn't assign it to a variable or call any methods on it. Consider storing the instance in a variable to make the test's intent clearer and potentially test additional behavior.
new Updater(
Co-authored-by: Copilot <[email protected]>
rickreyhsig
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting index-url if it's not there when url is present.