extract registry from url for other ecosystems #1520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the registry URL parsing logic into a reusable method and extends support for additional package ecosystem types. The change builds on previous work to handle URL-to-registry conversion for credential types beyond just npm.
- Refactored inline URL parsing logic into a dedicated
setRegistryFromUrlmethod - Extended registry extraction support to include
composer_repositoryanddocker_registrytypes - Added comprehensive test coverage for the new credential types
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/updater.ts | Extracted URL-to-registry parsing logic into a reusable method and added support for composer and docker registry types |
| tests/updater.test.ts | Added test cases for docker and composer credential types to verify registry extraction from URLs |
Co-authored-by: Copilot <[email protected]>
honeyankit
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two more registry types that could use the URL -> registry behavior.