Skip to content

Conversation

@etr
Copy link
Owner

@etr etr commented Feb 11, 2019

Description of the Change

This change adds a data closure that is passed through the cycle_callback of a deferred response.

Alternate Designs

A couple of pull requests have been proposed to tackle this:

Possible Drawbacks

This adds a template to the deferred_response effectively complicating the interface.

Verification Process

Performed tests on travis.

Release Notes

It is now possible to pass a data closure through the cycle_callback of a deferred response.

@etr etr self-assigned this Feb 11, 2019
@etr etr added feature-request Feature requests or enhancements api Related to libhttpserver's public APIs. labels Feb 11, 2019
@codecov-io
Copy link

codecov-io commented Feb 11, 2019

Codecov Report

Merging #145 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   96.46%   96.55%   +0.09%     
==========================================
  Files          34       34              
  Lines        2995     3019      +24     
==========================================
+ Hits         2889     2915      +26     
+ Misses        106      104       -2
Impacted Files Coverage Δ
test/integ/deferred.cpp 100% <100%> (ø) ⬆️
src/httpserver/deferred_response.hpp 100% <100%> (ø) ⬆️
src/deferred_response.cpp 100% <100%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead9ccc...ed0841d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to libhttpserver's public APIs. feature-request Feature requests or enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants