-
Notifications
You must be signed in to change notification settings - Fork 334
Build Ruby 4.0 with ZJIT #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'll double-check if this successfully compiles on all architectures once the next preview is out. It should support the same architectures as YJIT does. |
48b7879 to
166d357
Compare
|
Since ruby/ruby#15368 ZJIT is compiled in automatically as long as the rust version allows it. This is ready now |
Dockerfile.template
Outdated
| --enable-shared \ | ||
| ${rustArch:+--enable-yjit} \ | ||
| {{ if env.version | IN("3.2", "3.3", "3.4") then "" else ( -}} | ||
| ${rustArch:+--enable-zjit} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace nit: 😅
| ${rustArch:+--enable-zjit} \ | |
| ${rustArch:+--enable-zjit} \ |
More details at https://bugs.ruby-lang.org/issues/21221 ZJIT requires rust 1.85, so bump the version.
|
Thank you! ❤️ Let's do this 👀 |
Changes: - docker-library/ruby@84bfd8d: Merge pull request docker-library/ruby#509 from Earlopain/zjit - docker-library/ruby@55e358c: Build Ruby 4.0 or greater with zjit
Changes: - docker-library/ruby@84bfd8d: Merge pull request docker-library/ruby#509 from Earlopain/zjit - docker-library/ruby@55e358c: Build Ruby 4.0 or greater with zjit Co-authored-by: Docker Library Bot <[email protected]>
zjit is the next big thing and at least one character better than yjit.
It currently lags behind yjit in many areas but commiters expect it to be ready and on par with yjit by the time 3.5 actually releases.
https://bugs.ruby-lang.org/issues/21221
3.5-preview1 doesn't actually contain any code for ZJIT, so this will be a draft for a while until it actually makes sense.