Skip to content

Fix typing: export the identified w/ declared type #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jviide merged 1 commit into from
Feb 4, 2020
Merged

Fix typing: export the identified w/ declared type #153

jviide merged 1 commit into from
Feb 4, 2020

Conversation

@yhatt
Copy link
Contributor

@yhatt yhatt commented Jan 29, 2020

Resolves #152.

index.d.ts should export the identified value with declared type, not the actual type.

@yhatt yhatt mentioned this pull request Jan 29, 2020
Merged
3 tasks
@exKAZUu exKAZUu mentioned this pull request Jan 30, 2020
Open
@yhatt yhatt mentioned this pull request Jan 30, 2020
Merged
@yhatt yhatt requested a review from jviide January 31, 2020 07:31
@jviide
Copy link
Collaborator

jviide commented Feb 4, 2020

Thank you, @yhatt!

@jviide jviide merged commit 46852ce into developit:master Feb 4, 2020
@yhatt yhatt deleted the fix-type branch February 5, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jviide jviide jviide approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeScript throws compile error TS2714 in dist/htm.d.ts

2 participants

@yhatt @jviide