add preact hooks to the standalone bundle #134
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fragments would also be useful! Eg. haunted https://github.com/matthewp/haunted#lighterhtml-etc provides a nice way to make web-components react components. |
|
Hi, What's the status on this PR? |
Owner
|
Hiya - sorry for the radio silence on this one. The trick here is figuring out what folks are relying on I think we can merge this, since it still allows the non-standalone preact integration to work with Preact 8. |
developit
approved these changes
Dec 24, 2019
Collaborator
|
Thanks @zserge! |
|
Hello all, is this change released yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds exported preact/hooks functions to the standalone bundle, so that one can use htm + preact + useState etc from a single module.
I believe that Preact 10.0.0+ gains a lot from using hooks, also this functionality was requested in the relevant issue issue: #46 (comment)
There might be a better way to resolve this, if so - I'd be happy to adjust the PR.