Skip to content

ci(testing): run tests on all major platforms #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tlacenka merged 4 commits into from
Oct 29, 2023
Merged

ci(testing): run tests on all major platforms #166

Tlacenka merged 4 commits into from
Oct 29, 2023

Conversation

@Tlacenka
Copy link
Collaborator

@Tlacenka Tlacenka commented Oct 27, 2023 •
edited
Loading

In this PR, I add matrix for running both unit and E2E tests on all three major platforms (Linux, Windows, MacOS).

  • All jobs should run in parallel, so having all three platforms covered should not have any drawbacks.
  • Even if one job fails, the other tests are executed.
  • Timeout for E2E is increased due to slower execution in pipelines (mainly Windows).
  • Unfortunately, the tests are currently flaky. I added one retry until this issue is resolved.

@Tlacenka Tlacenka self-assigned this Oct 27, 2023
@Tlacenka Tlacenka added the 🦾 CI/CD Continuous integration and deployment label Oct 27, 2023
@Tlacenka Tlacenka linked an issue Oct 27, 2023 that may be closed by this pull request
Test on Windows in CI #141
Closed
1 task
@Tlacenka Tlacenka added the 🚧 blocked blocked issue label Oct 27, 2023
@Tlacenka Tlacenka force-pushed the 141-ci-run-tests-on-different-platforms branch from 4b04522 to e146be6 Compare October 27, 2023 12:49
@Tlacenka Tlacenka removed the 🚧 blocked blocked issue label Oct 27, 2023
@Tlacenka Tlacenka force-pushed the 141-ci-run-tests-on-different-platforms branch from e146be6 to 9280163 Compare October 27, 2023 13:20
@Tlacenka Tlacenka force-pushed the 141-ci-run-tests-on-different-platforms branch from 9280163 to 835c2b3 Compare October 27, 2023 13:30
MishaSeredenkoPushBased
MishaSeredenkoPushBased reviewed Oct 27, 2023
View reviewed changes
@matejchalk matejchalk mentioned this pull request Oct 29, 2023
Merged
@Tlacenka Tlacenka force-pushed the 141-ci-run-tests-on-different-platforms branch from 835c2b3 to 1bee80d Compare October 29, 2023 12:40
@Tlacenka Tlacenka merged commit 378e1c1 into main Oct 29, 2023
@Tlacenka Tlacenka deleted the 141-ci-run-tests-on-different-platforms branch October 29, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalk matejchalk matejchalk approved these changes

@BioPhoton BioPhoton Awaiting requested review from BioPhoton

+1 more reviewer

@MishaSeredenkoPushBased MishaSeredenkoPushBased MishaSeredenkoPushBased left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Tlacenka Tlacenka

Labels

🦾 CI/CD Continuous integration and deployment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test on Windows in CI

4 participants

@Tlacenka @matejchalk @MishaSeredenkoPushBased