Skip to content

Conversation

@matejchalk
Copy link
Collaborator

Part of #888

Adds info and debug logs to the ESLint plugin:

  • rules detection
  • group creation
  • config format detection
  • artifact loading
  • lint results stats

Also added a utility that prefixes logs from functions executed in code-pushup.config.ts with the plugin title, so users can tell which plugin is producing the log.

Examples (local)

Multiple Nx targets

screen-capture.-.2025-12-10T165552.648.webm
image image

Single target, artifacts

image

@nx-cloud
Copy link

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit 89c0468

Command Status Duration Result
nx affected -t int-test --parallel=3 ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-10 17:40:15 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1176

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1176

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1176

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1176

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1176

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1176

@code-pushup/axe-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/axe-plugin@1176

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1176

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1176

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1176

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1176

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1176

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1176

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1176

commit: 89c0468

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit da08c3a with previous commit 38ad415.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 73 🔴 39 ↓ −34.1
Documentation 🔴 35 🔴 35 ↓ −0.1
Code coverage 🟡 89 🟡 89 ↑ +0.1
Bug prevention 🟡 67 🟡 67
Code style 🟢 100 🟢 100
Security 🔴 43 🔴 43
Updates 🟡 71 🟡 71
Type Safety 🟡 56 🟡 56
Miscellaneous 🟡 67 🟡 67
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟢 92 🟢 92
👍 1 group improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 11 audits regressed, 9 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 73 🔴 39 ↓ −34.1
JSDoc coverage Documentation coverage 🔴 35 🔴 35 ↓ −0.1
Code coverage Code coverage metrics 🟡 89 🟡 89 ↑ +0.1

31 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 780 ms 🟩 Root document took 540 ms ↓ −31.5 %
Lighthouse Total Blocking Time 🟨 280 ms 🟥 1,350 ms ↑ +376.4 %
Lighthouse Largest Contentful Paint 🟨 3.7 s 🟥 11.3 s ↑ +208.3 %
Lighthouse Max Potential First Input Delay 🟨 220 ms 🟥 1,100 ms ↑ +390.6 %
Lighthouse Reduce unused JavaScript 🟨 Potential savings of 187 KiB 🟥 Potential savings of 187 KiB ↑ +∞ %
Lighthouse Remove duplicate modules in JavaScript bundles 🟨 Potential savings of 106 KiB 🟥 Potential savings of 106 KiB ↑ +∞ %
Lighthouse Speed Index 🟨 5.6 s 🟥 6.1 s ↑ +8.4 %
Lighthouse Time to Interactive 🟥 11.5 s 🟥 12.5 s ↑ +8.8 %
Lighthouse First Contentful Paint 🟥 3.1 s 🟥 3.1 s ↓ −1.6 %
Code coverage Line coverage 🟨 84.7 % 🟨 84.8 % ↑ +0.1 %
Code coverage Branch coverage 🟨 87.2 % 🟨 87.1 % ↓ −0.1 %
JSDoc coverage Functions coverage 🟥 556 undocumented functions 🟥 559 undocumented functions ↑ +0.5 %
JSDoc coverage Types coverage 🟥 243 undocumented types 🟥 244 undocumented types ↑ +0.4 %
Code coverage Function coverage 🟩 90.4 % 🟩 90.5 % ↑ +0.1 %
JSDoc coverage Variables coverage 🟥 251 undocumented variables 🟥 253 undocumented variables ↑ +0.8 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,039 KiB 🟩 Total size was 2,048 KiB ↑ +0.4 %
Lighthouse Minimizes main-thread work 🟥 3.8 s 🟥 9.4 s ↑ +146 %
Lighthouse JavaScript execution time 🟥 1.3 s 🟥 3.7 s ↑ +183.8 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +8.8 %
Lighthouse Server Backend Latencies 🟩 400 ms 🟩 1,390 ms ↑ +244.9 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↓ −0.1 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 94 KiB 🟥 Potential savings of 94 KiB ↓ −37.5 %
Lighthouse Network Round Trip Times 🟩 100 ms 🟩 20 ms ↓ −76.7 %
TypeScript Semantic errors 🟥 2626 errors 🟥 2636 errors ↑ +0.4 %

654 other audits are unchanged.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit da08c3a with previous commit 38ad415.

💼 Project plugin-eslint

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🟡 66 🟡 66 ↓ −0.1
Code coverage 🟢 94 🟢 94 ↑ +0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 1 audit changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDoc coverage Documentation coverage 🟡 66 🟡 66 ↓ −0.1
Code coverage Code coverage metrics 🟢 94 🟢 94 ↑ +0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDoc coverage Variables coverage 🟥 13 undocumented variables 🟥 15 undocumented variables ↑ +15.4 %
Code coverage Line coverage 🟩 91.8 % 🟩 92.5 % ↑ +0.8 %
JSDoc coverage Functions coverage 🟥 46 undocumented functions 🟥 48 undocumented functions ↑ +4.3 %
Code coverage Branch coverage 🟨 85 % 🟨 84.7 % ↓ −0.4 %
Code coverage Function coverage 🟩 98.2 % 🟩 98.2 % ↑ +0.1 %
JSDoc coverage Types coverage 🟥 14 undocumented types 🟥 15 undocumented types ↑ +7.1 %

437 other audits are unchanged.

💼 Project utils

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟢 95 🟢 95 ↑ +0.1
Documentation 🔴 38 🔴 38 ↓ −0.1

4 other categories are unchanged.

👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟢 95 🟢 95 ↑ +0.1
JSDoc coverage Documentation coverage 🔴 38 🔴 38 ↓ −0.1

13 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
JSDoc coverage Functions coverage 🟥 232 undocumented functions 🟥 233 undocumented functions ↑ +0.4 %
Code coverage Branch coverage 🟩 91.9 % 🟩 92 % ↑ +0.1 %
Code coverage Function coverage 🟩 95.5 % 🟩 95.5 % ↑ +0.1 %
Code coverage Line coverage 🟩 96.9 % 🟩 96.9 % ↑ +0.1 %

439 other audits are unchanged.


12 other projects are unchanged.

@matejchalk matejchalk marked this pull request as ready for review December 10, 2025 16:47
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice logger cleanup once again! I added a suggestion to fix type checks

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move code out of index.ts files to be able to exclude all index files from coverage. This applies to all index.ts files changed in this PR.

This is out of scope but up to you to include it here already.

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants