-
Notifications
You must be signed in to change notification settings - Fork 15
feat(plugin-eslint): log initializer and runner steps #1176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 89c0468
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/create-cli
@code-pushup/core
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit da08c3a with previous commit 38ad415. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 1 group improved, 👎 2 groups regressed, 👍 4 audits improved, 👎 11 audits regressed, 9 audits changed without impacting score🗃️ Groups
31 other groups are unchanged. 🛡️ Audits
654 other audits are unchanged. |
…eation, nx helpers)
7132d04 to
6d4c448
Compare
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit da08c3a with previous commit 38ad415. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Documentation | 🟡 66 | 🟡 66 | |
| Code coverage | 🟢 94 | 🟢 94 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 1 audit changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| JSDoc coverage | Documentation coverage | 🟡 66 | 🟡 66 | |
| Code coverage | Code coverage metrics | 🟢 94 | 🟢 94 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Variables coverage | 🟥 13 undocumented variables | 🟥 15 undocumented variables | |
| Code coverage | Line coverage | 🟩 91.8 % | 🟩 92.5 % | |
| JSDoc coverage | Functions coverage | 🟥 46 undocumented functions | 🟥 48 undocumented functions | |
| Code coverage | Branch coverage | 🟨 85 % | 🟨 84.7 % | |
| Code coverage | Function coverage | 🟩 98.2 % | 🟩 98.2 % | |
| JSDoc coverage | Types coverage | 🟥 14 undocumented types | 🟥 15 undocumented types |
437 other audits are unchanged.
💼 Project utils
🤨 Code PushUp report has both improvements and regressions.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 95 | 🟢 95 | |
| Documentation | 🔴 38 | 🔴 38 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 95 | 🟢 95 | |
| JSDoc coverage | Documentation coverage | 🔴 38 | 🔴 38 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDoc coverage | Functions coverage | 🟥 232 undocumented functions | 🟥 233 undocumented functions | |
| Code coverage | Branch coverage | 🟩 91.9 % | 🟩 92 % | |
| Code coverage | Function coverage | 🟩 95.5 % | 🟩 95.5 % | |
| Code coverage | Line coverage | 🟩 96.9 % | 🟩 96.9 % |
439 other audits are unchanged.
12 other projects are unchanged.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice logger cleanup once again! I added a suggestion to fix type checks
6d4c448 to
89c0468
Compare
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move code out of index.ts files to be able to exclude all index files from coverage. This applies to all index.ts files changed in this PR.
This is out of scope but up to you to include it here already.
BioPhoton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Part of #888
Adds info and debug logs to the ESLint plugin:
Also added a utility that prefixes logs from functions executed in
code-pushup.config.tswith the plugin title, so users can tell which plugin is producing the log.Examples (local)
Multiple Nx targets
screen-capture.-.2025-12-10T165552.648.webm
Single target, artifacts