Sanitizing #180 #193
Merged
Sanitizing #180 #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support of `config.tunnel_pid` and cli `—pid` param - It should be a string like “/dir1/dir2/file.pid” to save process id - It will allow external process to control the tunnel process - If automated jobs for browserstack hanged or shutdown, we want to kill previous tunnel process manually before starting tests again. * Add support of `config.test_server_port` param - If not set, the default 8888 port is used - List of support ports: https://www.browserstack.com/question/664
* Renaming config.tunnel_pid to config.tunnel_pid_file * Regex match for --pid instead of -pid * Error message on invalid flag
mjawa
approved these changes
Dec 7, 2017
vedharish
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#180