MINOR: code cleanup in InternalTopicManager

[mjsax]

• Avoid double-brace initialization
• Fix timeout error handling, by pass in correct list of topic names
• Remove unnecessary code

Reviewers: Vincent Potuček (@Pankraz76), Lucas Brutschy
[email protected]

[Pankraz76]

interesting syntax. Its like an array init, within the declaration, right?

Does is make an performance difference, or is it just error prone, thus some kind of community convent to avoid?

[mjsax]

Its like an array init, within the declaration, right?

Yes. Similar.

Does is make an performance difference, or is it just error prone, thus some kind of community convent to avoid?

It's not considered best practice. Overlooked during code-review. From Copilot:

Using double-brace initialization creates an anonymous inner class and can lead to memory leaks. Consider using a standard HashSet construction with addAll() calls or collect the items into a set using streams.

[Pankraz76]

thanks for the hint, its even an error lvl warning.

This should be done the right way to ensure its done overall and not just somewhere. Human interaction can not scale this issue accordingly.

• https://errorprone.info/bugpattern/DoubleBraceInitialization
• https://docs.openrewrite.org/recipes/staticanalysis/nodoublebraceinitialization

[mjsax]

I agree that it would be great to fail the build for this. Would you be interested to look into it, and do a PR changing the gradle setup, and fix any potentially lingering code that uses double-brace initialization?

[Pankraz76]

already on it, thank you for initiative.

[lucasbru]

LGTM, thanks