Support python 3.12 #1068
Merged
Support python 3.12 #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
reviewed
Aug 16, 2024
| numpy = { version = "^1.22.4", optional = true } | ||
| numpy = [ | ||
| { version = "1.26.0", python = ">=3.9,<3.13", optional = true }, | ||
| { version = "1.24.4", python = ">=3.8,<3.9", optional = true } |
Contributor
There was a problem hiding this comment.
3.8 is also almost EOL: https://devguide.python.org/versions/
Contributor
Author
There was a problem hiding this comment.
Created issue to track this
Fokko
reviewed
Aug 16, 2024
| default: true | ||
|
|
||
| # MD013/line-length - Line length | ||
| MD013: false |
Contributor
There was a problem hiding this comment.
I really dislike fixed length :)
Fokko
approved these changes
Aug 16, 2024
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
@kevinjqliu this looks nice!
kevinjqliu
force-pushed
the
kevinjqliu/python-3.12
branch
from
421f22a to
3c502d6
Compare
ndrluis
approved these changes
Sep 3, 2024
Fokko
reviewed
Sep 5, 2024
Comment on lines
+618
to
+619
| "ignore:datetime.datetime.utcnow\\(\\) is deprecated and scheduled for removal in a future version.", | ||
| "ignore:datetime.datetime.utcfromtimestamp\\(\\) is deprecated and scheduled for removal in a future version.", |
Contributor
There was a problem hiding this comment.
Should we also create an issue for this one? Would be a good first issue for someone to get started with PyIceberg :)
Fokko
approved these changes
Sep 5, 2024
This was referenced Sep 5, 2024
Closed
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
sungwy
pushed a commit
to sungwy/iceberg-python
that referenced
this pull request
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for python 3.12 to the PyIceberg project. It includes building and releasing for python version 3.12.
python-ciGithub Action; works for python 3.12 (Github Action run)python-releaseGithub Action; works for python 3.12 (Github Action run via my forked repo)Pre-req: #1118, update markdown linter to use
markdownlintwhich supports python 3.12Closes #28