fix: add -- separator to git diff HEAD command #14513
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the -- separator to 'git diff HEAD' command to prevent ambiguity when a file named 'HEAD' exists in the working directory. This follows git best practices for separating revision arguments from file paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--separator togit diff HEADcommand in commit-commands pluginProblem
The current implementation uses
git diff HEADwithout the--separator. This can cause issues when a file namedHEADexists in the working directory, as git may interpret it ambiguously.Solution
Changed
git diff HEADtogit diff HEAD --to explicitly separate revision arguments from file paths, following git best practices.Test plan