Skip to content

Conversation

@AloisJasa
Copy link
Contributor

motivation – Less Code Is More :)

Prepared methods for common situations – 3 lines of code

$settings->addMappingFieldKeyword(ProductMappingProperty::PROPERTY_ENTITY_ID);
$settings->addMappingFieldKeyword(ProductMappingProperty::PROPERTY_EAN);
$settings->addMappingFieldFloat(ProductMappingProperty::PROPERTY_PRICE_INC_VAT);

instead of 18 lines of code

		$settings->addMappingField(
			new \Spameri\ElasticQuery\Mapping\Settings\Mapping\Field(
				PROPERTY_ENTITY_ID,
				\Spameri\Elastic\Model\ValidateMapping\AllowedValues::TYPE_KEYWORD
			)
		);
		$settings->addMappingField(
			new \Spameri\ElasticQuery\Mapping\Settings\Mapping\Field(
				PROPERTY_EAN,
				\Spameri\Elastic\Model\ValidateMapping\AllowedValues::TYPE_KEYWORD
			)
		);
		$settings->addMappingField(
			new \Spameri\ElasticQuery\Mapping\Settings\Mapping\Field(
				PROPERTY_PRICE_INC_VAT,
				\Spameri\Elastic\Model\ValidateMapping\AllowedValues::TYPE_FLOAT
			)
		);

@Spamercz Spamercz changed the base branch from master to version-one January 6, 2022 09:47
@AloisJasa AloisJasa changed the base branch from version-one to master January 30, 2022 21:02
@Spamercz Spamercz changed the base branch from master to version-one February 23, 2022 14:05
@Spamercz Spamercz merged commit 627d74c into Spameri:version-one Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants