Skip to content

Remove match keyword from class names (atc.) for PHP8.0+ (for version-one breanch) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Spamercz merged 1 commit into from
Sep 29, 2021
Merged

Remove match keyword from class names (atc.) for PHP8.0+ (for version-one breanch) #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/01-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# Using with [ElasticSearch/ElasticSearch](https://github.com/elastic/elasticsearch-php)
First we need to prepare query for what we want to search.

```php
$query = new \Spameri\ElasticQuery\ElasticQuery();
$query->query()->must()->add(
new \Spameri\ElasticQuery\Query\Match(
new \Spameri\ElasticQuery\Query\ElasticMatch(
'name',
'Avengers'
)
Expand Down
2 changes: 1 addition & 1 deletion src/Query/Match.php → src/Query/ElasticMatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
/**
* @see https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-match-query.html
*/
class Match implements \Spameri\ElasticQuery\Query\LeafQueryInterface
class ElasticMatch implements \Spameri\ElasticQuery\Query\LeafQueryInterface
{

private string $field;
Expand Down
2 changes: 1 addition & 1 deletion tests/SpameriTests/ElasticQuery/ElasticQuery.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class ElasticQuery extends \Tester\TestCase

public function testCreate() : void
{
$match = new \Spameri\ElasticQuery\Query\Match(
$match = new \Spameri\ElasticQuery\Query\ElasticMatch(
'name',
'Avengers',
1.0,
Expand Down
6 changes: 3 additions & 3 deletions ...pameriTests/ElasticQuery/Query/Match.phpt → ...ests/ElasticQuery/Query/ElasticMatch.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace SpameriTests\ElasticQuery\Query;
require_once __DIR__ . '/../../bootstrap.php';


class Match extends \Tester\TestCase
class ElasticMatch extends \Tester\TestCase
{

private const INDEX = 'spameri_test_video_match';
Expand All @@ -26,7 +26,7 @@ class Match extends \Tester\TestCase

public function testCreate() : void
{
$match = new \Spameri\ElasticQuery\Query\Match(
$match = new \Spameri\ElasticQuery\Query\ElasticMatch(
'name',
'Avengers',
1.0,
Expand Down Expand Up @@ -101,4 +101,4 @@ class Match extends \Tester\TestCase

}

(new Match())->run();
(new ElasticMatch())->run();