-
Notifications
You must be signed in to change notification settings - Fork 8
V2 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Spamercz
wants to merge
88
commits into
master
Choose a base branch
from
v2.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added to version provider - Updated diagnostics panel - Changed to new client object from elasticsearch repo
- To track what entity is loaded and if it is changed
to be used in creating related entities
- iterates child entities and dispatches events on them
- if entity exists in identity map with that id/index combination it is returned instead of getting it from Elasticsearch - after entity is inserted to elasticsearch, that entity is also stored in identitymap
PrepareEntityArray: - Entities must extend AbstractElasticEntity (to utilize its requirement of id method) - Handled entities are added to identityMap, to prevent insert loop (entity is inserted only once if it is missing in identityMap or is changed) - Persisting is handled via entityManager instead of services (deprecated method) - Added support for "STI" entities, ie to help entity factory figure out what class it should create when fetching from elasticsearch - Utilizes special key entityClass in its data to store entity class EntityFactory: - To figure out what entity to create (and child entities) that has abstract type or is just interface, new metadata were added - EntityClass - If property has type that is interface, then this metadata is used to figure out what entity should be created - This enables to use "STI" mechanic, without developer involvement, it happens automatically - Uses identityMap, if entity is allready created it skips creating and returns that version - Uses ChangeSet to figure out what entities and specially child entities were changed.
b274605 to
4a397d9
Compare
… on load. This is logged as critical exception but not thrown (due to entity may be deleted so you have to cleaup your data)
…f circular reference, so entity is not loaded multiple times
…ed, so it does not initialize in loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.