Skip to content

Conversation

@VirxEC
Copy link
Collaborator

@VirxEC VirxEC commented Dec 26, 2025

Fixes #37

@VirxEC VirxEC changed the title Properly update Renderer.can_render (Fixes #37) Properly update Renderer.can_render Dec 26, 2025
Copy link
Contributor

@NicEastvillage NicEastvillage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this solution is ideal as it couples the renderer to the manager and will it not work correctly without it, thus reducing flexibility. For example, I cannot make a custom renderer and have its can_render flag update, unless I store it as self.renderer in my bot or override the msg handler.

I suggest putting the can_render flag on the RLBotInterface and then have the managers and the renderer read that flag instead.

E.g. in the renderer:

@property
def can_render():
    self._game_interface.can_render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Renderer.can_render has the wrong initial value

3 participants