Skip to content

[MemFS] Release memory when close() is called #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willmcgugan merged 4 commits into from
Jul 28, 2019
Merged

[MemFS] Release memory when close() is called #313

willmcgugan merged 4 commits into from
Jul 28, 2019

Conversation

@dargueta
Copy link
Contributor

@dargueta dargueta commented Jul 24, 2019 •
edited
Loading

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

MemFS now immediately releases the memory used up by its files when close() is called, rather than when the file system gets garbage collected. Closes #308 .

@coveralls
Copy link

coveralls commented Jul 24, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 99.078% when pulling d3c8d5a on dargueta:memoryfs-close into 37b46b4 on PyFilesystem:master.

willmcgugan
willmcgugan requested changes Jul 25, 2019
View reviewed changes
tests/test_memoryfs.py
posixpath.join(parent_dir, str(file_id)), UNICODE_TEXT
)

@unittest.skipIf(
Copy link
Member

@willmcgugan willmcgugan Jul 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough test 👍

lurch
lurch reviewed Jul 25, 2019
View reviewed changes
@dargueta
Copy link
Contributor Author

dargueta commented Jul 26, 2019

I know the contributors list is supposed to be sorted alphabetically but do I really need to put my name at the top? Feels weird.

@willmcgugan
Copy link
Member

willmcgugan commented Jul 26, 2019

@dargueta It's cool. The idea was that the order doesn't indicate significance of contribution.

PR looks good BTW, thanks. I'll give it another review soon.

@willmcgugan
Copy link
Member

willmcgugan commented Jul 28, 2019

Thanks

@willmcgugan willmcgugan merged commit ef8682b into PyFilesystem:master Jul 28, 2019
@mostafa
Copy link

mostafa commented Jul 28, 2019

Thanks

@dargueta dargueta deleted the memoryfs-close branch July 29, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lurch lurch lurch left review comments

@willmcgugan willmcgugan willmcgugan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Free memory on MemoryFS.close

5 participants

@dargueta @coveralls @willmcgugan @mostafa @lurch