shipwright: enable fetchTags #473003
Open
shipwright: enable fetchTags #473003
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Aleksanaa
reviewed
Dec 21, 2025
| cd $out | ||
| git branch --show-current > GIT_BRANCH | ||
| git rev-parse --short=7 HEAD > GIT_COMMIT_HASH | ||
| (git describe --tags --abbrev=0 --exact-match HEAD 2>/dev/null || echo "") > GIT_COMMIT_TAG |
Member
There was a problem hiding this comment.
But this is relying on tags... Maybe you should use leaveDotGit = true; and delete .git manually?
Contributor
Author
There was a problem hiding this comment.
deepclone implies leavedotgit, which we do remove below. Adding fetchTags reverts to previous behavior. I'm having trouble with using git describe --tags in the new postCheckout.
qubitnano
changed the title
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hash was invalidated due to recent fetchgit changes involving tags: 7e08567
#465497
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.