Fix linker file path support, add `ObjectCode` constructor tests for `ltoir` inputs, and expose `code_type` #890

Copilot · 2025-08-22T02:02:16Z

Fix linker file path support for ObjectCode constructors
Add comprehensive test coverage for ObjectCode constructor methods
Flatten nested if statements for better readability
Remove redundant tests and improve test organization
Implement NVCC-based testing for fatbin and object/library tests
Add missing test_object_code_load_ptx_from_file and group tests properly
Remove self-explanatory comments and clarify conditional logic in linker

Bug Fix Complete: Fixed TypeError: Expected type bytes, but got str when using ObjectCode instances created from file paths with the Linker class.

Test Coverage Complete: Added comprehensive tests for all ObjectCode constructor methods (from_ltoir, from_fatbin, from_object, from_library) with both file-based and in-memory variants, plus integration tests with the Linker class.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

copy-pr-bot · 2025-08-22T02:02:19Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

…object, and from_library constructors Co-authored-by: leofang <[email protected]>

…value validation Co-authored-by: leofang <[email protected]>

leofang

@copilot I think you missed my comment #663 (comment), in particular Step 1 there. We need to make sure files on disk can be also consumed by the linker.

Co-authored-by: leofang <[email protected]>

leofang

@copilot

cuda_core/cuda/core/experimental/_linker.py

Co-authored-by: leofang <[email protected]>

Copilot · 2025-08-25T00:27:20Z

@copilot

Step 1 from your original comment is already implemented in the current code. The linker now properly handles both file paths (str) and in-memory data (bytes) for ObjectCode instances:

File paths use nvjitlink.add_file() or cuLinkAddFile()
In-memory bytes use add_data() methods
Added comprehensive test coverage including integration tests

The bug where the linker crashed with "TypeError: Expected type bytes, but got str" when using file-based ObjectCode has been resolved.

leofang

@copilot

btw I noticed that there's still one test missing: test_object_code_load_ptx_from_file. Please add it, and make sure it's placed close to test_object_code_load_ptx. Please also group test_object_code_load_cubin and test_object_code_load_cubin_from_file together for better clarity.

cuda_core/tests/test_module.py

…x fixture naming Co-authored-by: leofang <[email protected]>

Copilot · 2025-08-25T00:57:49Z

@copilot

btw I noticed that there's still one test missing: test_object_code_load_ptx_from_file. Please add it, and make sure it's placed close to test_object_code_load_ptx. Please also group ...

Added the missing test_object_code_load_ptx_from_file test and grouped the CUBIN and PTX tests together properly. The PTX tests are now adjacent to each other, and CUBIN tests are grouped. Commit: 5609cb1

leofang · 2025-09-17T23:21:24Z

pre-commit.ci fix

leofang · 2025-09-17T23:22:57Z

pre-commit.ci autofix

leofang · 2025-10-06T01:33:31Z

To make it easier to review, I've removed the ObjectCode constructor tests for the object, library, and fatbin inputs added by the Copilot. We can revisit this later.

leofang · 2025-10-06T01:34:30Z

/ok to test 727ead5

leofang · 2025-10-06T01:34:46Z

@brandon-b-miller could you review? 🙂

leofang · 2025-10-06T01:37:41Z

ping @benhg too

cuda_core/cuda/core/experimental/_linker.py

github-actions · 2025-10-07T19:46:08Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

Initial plan

afb4bd8

Copilot AI assigned Copilot and leofang Aug 22, 2025

github-project-automation bot added this to CCCL Aug 22, 2025

github-project-automation bot moved this to Todo in CCCL Aug 22, 2025

Copilot started work on behalf of leofang August 22, 2025 02:02 View session

Copilot AI and others added 2 commits August 22, 2025 02:08

Add comprehensive tests for ObjectCode from_ltoir, from_fatbin, from_…

b2bbf37

…object, and from_library constructors Co-authored-by: leofang <[email protected]>

Enhance ObjectCode constructor tests with error handling and default …

abbb07a

…value validation Co-authored-by: leofang <[email protected]>

Copilot AI changed the title ~~[WIP] [FEA]: Tests for ltoir, fatbin, object, and library constructors~~ Add comprehensive tests for ObjectCode constructor methods Aug 22, 2025

Copilot finished work on behalf of leofang August 22, 2025 02:11

Copilot AI requested a review from leofang August 22, 2025 02:11

leofang requested changes Aug 24, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in CCCL Aug 24, 2025

Copilot started work on behalf of leofang August 24, 2025 05:41 View session

Fix linker to handle file paths for ObjectCode constructors

9ee5bfc

Co-authored-by: leofang <[email protected]>

Copilot AI changed the title ~~Add comprehensive tests for ObjectCode constructor methods~~ Fix linker file path support and add comprehensive ObjectCode constructor tests Aug 24, 2025

Copilot AI requested a review from leofang August 24, 2025 05:50

Copilot finished work on behalf of leofang August 24, 2025 05:50

leofang requested changes Aug 25, 2025

View reviewed changes

cuda_core/cuda/core/experimental/_linker.py Outdated Show resolved Hide resolved

Copilot started work on behalf of leofang August 25, 2025 00:24 View session

Flatten nested if statements in linker _add_code_object method

f3aad44

Co-authored-by: leofang <[email protected]>

Copilot finished work on behalf of leofang August 25, 2025 00:28

Copilot AI requested a review from leofang August 25, 2025 00:28

leofang requested changes Aug 25, 2025

View reviewed changes

Copilot started work on behalf of leofang August 25, 2025 00:51 View session

Address review comments: reorganize tests, add NVCC-based testing, fi…

5609cb1

…x fixture naming Co-authored-by: leofang <[email protected]>

Copilot AI requested a review from leofang August 25, 2025 00:58

[pre-commit.ci] auto code formatting

68003ba

leofang closed this Sep 17, 2025

github-project-automation bot moved this from In Progress to Done in CCCL Sep 17, 2025

leofang reopened this Sep 17, 2025

github-project-automation bot moved this from Done to Needs Triage in CCCL Sep 17, 2025

leofang linked an issue Sep 25, 2025 that may be closed by this pull request

[FEA]: Tests for ltoir, fatbin, object, and library constructors #663

Open

1 task

leofang added 5 commits October 6, 2025 00:59

Merge branch 'main' into copilot/fix-663

fa33473

nit: reorder test to make it easier to follow

62e240d

rename fixture for clarity + purge object/library/fatbin tests for now

45d0b24

minor fixes

3665e41

make code_type public

727ead5

leofang changed the title ~~Fix linker file path support and add comprehensive ObjectCode constructor tests~~ Fix linker file path support, add ObjectCode constructor tests for LTO IR inputs, and expose code_type Oct 6, 2025

leofang mentioned this pull request Oct 6, 2025

Mmason nvidia/bugfix/lto linking NVIDIA/numba-cuda#474

Closed

leofang marked this pull request as ready for review October 6, 2025 01:34

leofang changed the title ~~Fix linker file path support, add ObjectCode constructor tests for LTO IR inputs, and expose code_type~~ Fix linker file path support, add ObjectCode constructor tests for ltoir inputs, and expose code_type Oct 6, 2025

This comment has been minimized.

Sign in to view

kkraus14 approved these changes Oct 7, 2025

View reviewed changes

cuda_core/cuda/core/experimental/_linker.py Show resolved Hide resolved

leofang approved these changes Oct 7, 2025

View reviewed changes

github-project-automation bot moved this from Needs Triage to In Review in CCCL Oct 7, 2025

leofang merged commit 9bb7531 into main Oct 7, 2025
71 checks passed

leofang deleted the copilot/fix-663 branch October 7, 2025 19:33

github-project-automation bot moved this from In Review to Done in CCCL Oct 7, 2025

leofang mentioned this pull request Oct 7, 2025

[FEA]: Tests for ltoir, fatbin, object, and library constructors #663

Open

1 task

Fix linker file path support, add ObjectCode constructor tests for ltoir inputs, and expose code_type #890

Fix linker file path support, add ObjectCode constructor tests for ltoir inputs, and expose code_type #890

Uh oh!

Conversation

Copilot AI commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Aug 22, 2025

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Aug 25, 2025

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Aug 25, 2025

Uh oh!

leofang commented Sep 17, 2025

Uh oh!

leofang commented Sep 17, 2025

Uh oh!

leofang commented Oct 6, 2025

Uh oh!

leofang commented Oct 6, 2025

Uh oh!

leofang commented Oct 6, 2025

Uh oh!

leofang commented Oct 6, 2025

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix linker file path support, add `ObjectCode` constructor tests for `ltoir` inputs, and expose `code_type` #890

Fix linker file path support, add `ObjectCode` constructor tests for `ltoir` inputs, and expose `code_type` #890

Copilot AI commented Aug 22, 2025 •

edited

Loading